If we're talking about immigrants writ large: It depends.
If we're talking specifically about *illegal* immigrants: It still depends.
Plenty of visas are only for a few years, and that's fine. I think having some temporary worker programs are good...they don't necessarily all need a path to citizenship. The big problem is when meritocratic entries (e.g. student visas and H1B visas) don't have any path to citizenship. We should fix that by letting them get green cards when their temporary visa expires.
As for illegal immigrants...generally I'd say that amnesty for some of them is a better goal than a path to citizenship. Amnesty which lets them continue to live and work here, and which can be revoked if they break the law. But for the ones who get amnesty, it should come with the ability to apply for green cards for which they are qualified, such as being married to a US citizen. So it wouldn't reward them with a path to citizenship just for being an illegal immigrant, but it would grant them the same paths to citizenship open to applicants who aren't illegal immigrants.
I would support amnesty for illegal immigrants who can pass a background check and who have been here since, say, 2022, if they meet any one of the following criteria:
- They are married to a US citizen.
- They are the parent of an over-21 US citizen.
- They have a bachelor's degree.
- They served honorably in the US military.
- They can prove they entered the US before they were 18.
- They can prove they have lived in the US for 10+ years.