At this point, I'm beyond even considering his merit as a defense attorney. He's clearly been hired as a PR representative who happens to be an attorney, not the other way round. As has been suggested in a few earlier posts, it's plausible that he's not even tasked with presenting the truth of matters pertaining to Trump, but rather that his raison d'etre is to muddy waters, keep people confused, test/float potential lines of denial and deflection, attack the press, give "the base" straws to grasp, and just generally ensure the polity at large doesn't know what the hell to think.
That's not the sort of thing a PR agent does, but it's how Trump "rolls," so it's likely what he wants his PR agent to do since as POTUS and likely a subject/target of the Russian investigation, he can't himself do so without legally jeopardizing himself.
Aside:
If Trump survives as POTUS until 2020 and yet loses that election, I suspect he'll resign before the following inauguration so Pence (or Pence's replacement if Pence lasts that long) can pardon him. That's what I think is the plan right now. What I don't have a sense of is whether Pence would actually pardon him. What I do have a gut feeling about is that he'll be either in court or in jail, or both, from almost the day he leaves office 'til the day he dies.
